Add Dynatrace monitoring of MTA created by #1725
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boyan-velinov
force-pushed
the
mta-created-by-tracking
branch
2 times, most recently
from
51f9372 to
ed42982
Compare
| helper = new MtaArchiveHelper(manifest); | ||
| Map<String, List<String>> result = helper.getRequiresDependenciesFileAttributes(); | ||
| assertEquals(Map.of("config-bind.json", List.of("anatz/my-required-application", "anatz/my-required-application-2")), result); | ||
| assertNull(helper.getCreatedBy()); |
There was a problem hiding this comment.
This test method currently verifies two different behaviors: getRequiresDependenciesFileAttributes() and getCreatedBy(). To improve clarity and maintainability, it would be helpful to split these into separate test methods. That way, each test has a single responsibility and it will be easier to understand and maintain in the future.
boyan-velinov
force-pushed
the
mta-created-by-tracking
branch
from
ed42982 to
68626d9
Compare
|
s-yonkov-yonkov
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.